Closed
Conversation
Author
|
cc @ai |
Author
|
cc @RyanZim |
Collaborator
|
Is there some pressing need to upgrade from v3? If not, we might as well wait until we're working on the next major release, and then upgrade to v5 directly. |
Author
They have remove the glob support, but we have handle it in first |
Collaborator
|
Seems that the removal of glob support actually breaks things; tests are failing. |
Author
|
@RyanZim, i send the commit that i want to try in CI. |
Author
|
@RyanZim, all tests run successfully 🥳 |
Collaborator
|
Two problems with this approach:
|
Author
|
Maybe close this @RyanZim? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #501, but to
v4.chokidarversion 4 and up now only have 1 dependency, which is can make the install size is smaller and faster. But if you want tov5like #501, we must drop Nodejsv18and only supportv20.19.